Open
Conversation
AdnanHoque
reviewed
Apr 1, 2025
…file for both backward and forward to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adds a 'contiguous' group gemm with dynamic input and dynamic expert support. This is similar in spirit to the DeepSeek GEMM contiguous where inputs must be aligned to a given dimensionality of group_size_m and padded if not meeting that alignment.
1 - Forward and Backward are all working. See cg_forward.py and cg_backward.py:
Forward:
2 - demo.py and full_moe_e2e put all the pieces together for an implementation.
3 - cg_reference.py has the Pytorch reference equivalence.
Usage:
It is important to note that input tokens must be one expert per block, where block is defined as group_size_m. No mixing of experts within a block is allowed.